Recently a PR was opened to have pulp_ansible disable the “single commit check”. tl;dr I propose we remove that altogether and have Pulp repos use squash at merge time instead.
We added the single commit check so that when a change was merged we’d have a single commit if it needed to be backported.
It’s a friction for contribution. Folks have to squash their changes locally with every push to make it fully pass the CI. The more friction at contribution time the less contribution happens.
It doesn’t maintain a record of the work on a PR as it really happened.
Back then github has a “squash” option, but we had little to no control over what the commit message would read as. This was problematic both for clarity purposes but also for relating issue to Redmine. We don’t use Redmine anymore and github relates issues for us reliably now.
Additionally, github recently added a feature that allows us to control what the content of the commit message is.
First let’s have pulp_ansible try this change out. If it goes well, let’s remove the single-commit machinery from the plugin_template entirely and have all repos configured to only use “Allow squash merging”.