We discovered, that we have some pep8 bot running around on a number of repositories (~4?). It is complaining about styling issues, but we also enforce code style with black and flake8 (we do that properly as a merge requirement). So at the very least, the pep8bot is redundant. But i think it is also less then “not even helpful”, because the issues it keeps complaining about are not congruent with flake8.
We plan to disable this hopefully confuse less first time contributors in the future. If you feel different, please let us know.
3 Likes
+1 to “no weird redundant bots running around”
1 Like
If there are no objections we will disable it next Tuesday July 19th
2 Likes
I would not wait so long. It’s not even a change in the plugin template. Given the feedback, let’s just remove and see if anyone misses that bot comments.
BTW: There are conflicting claims between pep8 and black (which we use):
W503 line break before binary operator
see:
[0] https://github.com/pulp/pulp_ansible/pull/1117#issuecomment-1181480472
[1] https://github.com/pulp/plugin_template/blob/main/templates/bootstrap/flake8.cfg#L8
1 Like
fine by me.
I have removed pep8speaks from the Pulp github org.
2 Likes