decko
#21
2023-05-04 1300-1330 GMT-4
Attendees: decklo, bmbouter, ggainey, dalley
Regrets:
Agenda:
Notes
- “what does ‘done’ looks like?”
- complete aiohttp-instr-PR
- base-version of grafana panels done
- make a decision on how the packaging is going to work
- record two demo videos (jaeger/grafana)
- user-documentation
- pulpcore-docs?
- pulp-oci-images-docs?
- pulp-to-collector overview/connection
- “maybe” otel-cfg we’re using in oci-env?
- blog-post - can be ultra-specific, if/as desired
- api, pulp-specific instr, aiohttp, task-system
- api is in a great spot
- aiohttp is pretty good, but we really want it released upstream to consume
- nothing for tasking yet - phase-2 perhaps?
- pulp-specific hooks - phase-3?
- decko: need to have solid decision on packaging-discussion
- What we need to have OpenTelemetry working with Pulp?
- Collector container
- Bunch of dependencies
- opentelemetry-api
- opentelemetry-distro[otlp]
- opentelemetry-exporter-otlp-proto-http
- opentelemetry-exporter-otlp
- opentelemetry-instrumentation-wsgi
- opentelemetry-instrumentation-django
- opentelemetry-semantic-conventions
- opentelemetry-proto
- opentelemetry-sdk
- Instrumenting WSGI entrypoint (wsgi.py)
- The Faster Release Cycle…
- “We can undo it later if needed”
-
https://github.com/pulp/pulpcore/pull/3632
- we could accept the import of
opentelemetry.instrumentation.wsgi
today (it exists)
- the import of
opentelemetry.instrumentation.aiohttp_server
needs work that isn’t released in that upstream yet
- what can we do while waiting (if we have to)?
- fork the project? <== NO
- depend on the source-checkout? <== better
- vendor the PR?
- we’ll decide when we’ve done everything else we can do
- Decision:
- split aiohttp-mods out of current core-PR
- add trimmed dep-list
- release
- aiohttp-into-core gets its own PR
- requirements.txt relies on src-checkout
- merges once upstream accepts the needed changes
- bring this to pulpcore-mtg next week
Action Items:
- add notes to discourse
- schedule next mtg: The Road To Merge
1 Like
decko
#22
2023-05-11 1400-1430 GMT-3
Attendees: decko, bmbouter, dalley
Regrets:
Agenda:
- PR merging Otel dependencies and WSGI instrumentation - Done
- PR for opentelemetry-instrumentation-aiohttp-server. TBD
- We broke pulpcore CI!
Notes
- We need to add the OpenTelemetry libs as exception on the check_requirements plugin for the CI
Action Items:
- [decko] add notes to discourse
- [decko] Merge Otel oci-env profile
- [decko] Push the opentelemetry aiohttp-server PR
- [bmbouter] Fixes the plugin_template’s check_requirements.py
- [bmbouter] Gonna add worker telemetry
1 Like